search

8bitkick / BBCMicroBot

Runs your toot on an 8-bit computer emulator
GNU General Public License v3.0
110 stars 8 forks source link

Make MODE3 and 6 stripes non-transparent in PNGs #19

Closed ojwb closed 4 years ago

ojwb commented 4 years ago

They appear black on real hardware, but are transparent in jsbeeb's framebuffer and that transparency comes out in the PNG and looks wrong on a pale background.

ojwb commented 4 years ago

The CI failure is due to apt not finding the ffmpeg package in the repo. The tests pass locally.

ojwb commented 4 years ago

Rerunning the build seems to just try to rebuild the same failing build rather than merging with the lastest master, so I've rebased on the latest master and force-pushed.

ojwb commented 4 years ago

This seems non-controversial so I'm going to merge it.

The algorithm could perhaps be more nuanced, but I think it's a clear improvement over the current behaviour.