'PGPASSWORD' is not recognized as an internal or external command

8byr0 / strapi-plugin-backup-restore

Plugin to backup & restore your strapi installation (database + uploads) from admin panel.

MIT License

38 stars 3 forks source link

'PGPASSWORD' is not recognized as an internal or external command #3

Open shivagouraram opened 3 years ago

shivagouraram commented 3 years ago

Hi team,

Thanks for the great plugin. it looks like the plugin is not working on windows machines and I am getting the below error.

'PGPASSWORD' is not recognized as an internal or external command

Would it be possible to support this for windows as well as strapi supports it.

8byr0 commented 3 years ago

Thanks for reporting this, the pgdump command is actually called with PGPASSWORD=dbpassword pg_dump .... This way of setting env variables is not handled on some windows terminals, which is yours ?

I'll update the dump call to make it windows compatible, will let you know when the release is available !

shivagouraram commented 3 years ago

I am running my dev environment on Windows 10 locally and the actually production is on ubuntu. It works on ubuntu as expected but not on windows. On the other hand, I hope downloading the backup is only available for super admins by default - could you please confirm.

8byr0 commented 3 years ago

Release 0.5.1 is shipping out now!

It fixes your issue with env variable in windows. I delegated env management to exec which is used to run pg_dump. I assume they handle all platforms but since I only have OSX and linux I could not test in windows so please confirm that it's properly fixed.

Regarding your question on permissions, it was actually not handled so I've added such feature in the same release. You can now choose per role permissions for the plugin: