Closed Lycopersicum closed 6 years ago
Merging #16 into master-rest will decrease coverage by
33.34%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master-rest #16 +/- ##
================================================
- Coverage 65.04% 31.69% -33.35%
================================================
Files 9 26 +17
Lines 615 4010 +3395
================================================
+ Hits 400 1271 +871
- Misses 215 2739 +2524
Impacted Files | Coverage Δ | |
---|---|---|
core/transaction.c | 67.11% <100%> (ø) |
|
core/json.c | 0% <0%> (ø) |
|
core/uri.c | 45.45% <0%> (ø) |
|
core/data.c | 0% <0%> (ø) |
|
core/observe.c | 45.25% <0%> (ø) |
|
core/block1.c | 0% <0%> (ø) |
|
core/management.c | 19.31% <0%> (ø) |
|
examples/shared/commandline.c | 0% <0%> (ø) |
|
core/packet.c | 65.93% <0%> (ø) |
|
... and 8 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4a11a87...9d3f948. Read the comment docs.
I removed
transacP->ack_received
checking, because if observe cancellation is requested, sometimes two messages are detected, callingfree()
two times (which causes segmentation fault). To reproduce this problem:PUT
request to/subscriptions/<connected-sensor-UUID>/<path-to-resource>
(must be a valid, observable resource).DELETE
request to/subscriptions/<connected-sensor-UUID>/<path-to-resource>
(observation must be started already).If problem doesn't occur, repeat last two steps until it does.
Note: You can reproduce the problem only if observation removal is implemented.