✨ feat: worker and webhook autosacling

mhkarimi1383 commented 3 months ago

By adding webhookAutoscaling and workerAutoscaling

HPA will work for webhook and worker also fixes the problem where when autoscaling is enabled replicaCount will not work for webhook and worker

closes #80 closes #87

Summary by CodeRabbit

New Features
- Introduced Horizontal Pod Autoscaler (HPA) configurations for both webhook and worker components, enabling automated scaling based on resource utilization.
- Added granular autoscaling settings in the configuration file for improved resource management.
Bug Fixes
- Adjusted conditions for autoscaling checks to ensure correct scaling behavior for webhooks and workers.

coderabbitai[bot] commented 3 months ago

Walkthrough

The changes introduce more granular autoscaling configurations for both webhook and worker deployments in the n8n Helm chart. By creating dedicated settings for webhook and worker autoscaling, the modifications allow better management of pod replicas based on specific metrics, enhancing the control over resource allocation and scaling behavior. Additionally, new Horizontal Pod Autoscaler templates improve scalability and responsiveness to resource utilization.

Changes

Files	Change Summary
`charts/n8n/templates/deployment.webhooks.yaml`, `charts/n8n/templates/deployment.worker.yaml`	Updated autoscaling conditions to check specific webhook and worker autoscaling flags instead of a general one.
`charts/n8n/templates/hpa.webhook.yaml`, `charts/n8n/templates/hpa.worker.yaml`	Introduced new HPA configurations for webhooks and workers, dynamically adapting to Kubernetes versions.
`charts/n8n/values.yaml`	Added new autoscaling settings sections for workers and webhooks, allowing for detailed configuration.

Assessment against linked issues

Objective	Addressed	Explanation
Autoscaling worker pods (Issue #80)	✅
Setting autoscaling.enabled not affecting worker replicas (Issue #87)	✅

🐰
In the fields where bunnies hop,
Autoscaling changes make us stop!
Webhook and worker, side by side,
With metrics to guide and help them glide.
More control for pods, oh what a delight,
Scaling up and down, all through the night! 🌙✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

mhkarimi1383 commented 3 months ago

@Vad1mo Hi Can you review this?

Vad1mo commented 3 months ago

Thank you for the contribution, I'll test it out next week, when I am back. Maybe some other community members can give this PR a try too.

mhkarimi1383 commented 3 months ago

@Vad1mo Hi any updates?

Vad1mo commented 2 months ago

@mhkarimi1383 how does this relate to #110?

mhkarimi1383 commented 2 months ago

@Vad1mo I have not mentioned #110

RafaelTCostella commented 2 months ago

Any updates on this @Vad1mo? I believe that this would solve an issue for me too

Vad1mo commented 2 months ago

I would need to test it, did you guys use it? How does the values file look like?

mhkarimi1383 commented 2 months ago

I have done helm template command against changes It was OK

See two parts are added for auto scaling worker and webhook deployments (webhookAutoscaling and workerAutoscaling) config looks like older autoScaling

mhkarimi1383 commented 1 month ago

@Vad1mo

8gears / n8n-helm-chart