8gears / n8n-helm-chart

A Kubernetes Helm chart for n8n a Workflow Automation Tool. Easily automate tasks across different services.
https://artifacthub.io/packages/helm/open-8gears/n8n
Apache License 2.0
187 stars 97 forks source link

Service annotations not being written into n8n/templates/service.yaml #23

Closed kaifresh closed 1 year ago

kaifresh commented 2 years ago

I have defined some values in a values.yaml file for the Service like so (I am deploying on GKE and want to associate a BackendConfig with the Service)


service:
  type: ClusterIP
  port: 80
  annotations: # THIS ISNT BEING WRITTEN INTO THE TEMPLATED KUBERNETES CONFIG....
    # Backend Config created along side the ingress
    cloud.google.com/backend-config: '{"ports":{"http":"whitelist-cloudflare-only-via-security-policies", "https":"whitelist-cloudflare-only-via-security-policies"}}'

However, when I use the --dry-run and --debug flags, what I see is:

 ---
 # Source: n8n/templates/service.yaml
apiVersion: v1
 kind: Service
 metadata:
   name: n8n
   labels:
     helm.sh/chart: n8n-0.5.0
     app.kubernetes.io/name: n8n
     app.kubernetes.io/instance: n8n
     app.kubernetes.io/version: "0.111.0"
     app.kubernetes.io/managed-by: Helm
 spec:
   type: ClusterIP
   ports:
     - port: 80
       targetPort: http
       protocol: TCP
       name: http
   selector:
     app.kubernetes.io/name: n8n
     app.kubernetes.io/instance: n8n

Which suggests that the annotations part of the config referenced here is not being written into the template.

The question

Is my syntax wrong? The readme suggests annotations is just an object. Or is there something that needs to be changed in the template itself?

swarnat commented 1 year ago

Your version 0.5.0 of this chart don't contains the commit, which adds the annotations. I just tried in 0.6.0 (git master) and it works.

@Vad1mo Are you continue this repo or is it better to create a new chart on artifacthub with latest commits? Because the Chart in version 0.6.0 is working and just needs some love and polishing. :)

edit: Question answered, you continue this project thanks 👍

Vad1mo commented 1 year ago

@swarnat sorry this repo was neglected in the past, however we still use n8n and continue to support and update it.

Vad1mo commented 1 year ago

@swarnat happy if you could contribute a github action to build and push helm charts. I would like to migrate to OCI charts.