search

8gears / n8n-helm-chart

A Kubernetes Helm chart for n8n a Workflow Automation Tool. Easily automate tasks across different services.
https://artifacthub.io/packages/helm/open-8gears/n8n
Apache License 2.0
187 stars 97 forks source link

Annotations resource-policy is not longer managed by Helm v3 #8

Closed Igor992 closed 3 years ago

Igor992 commented 3 years ago

Hello,

Firstly, thanks for this great repository content and also for helmfile support! During testing this content I saw that there is still following annotation which Helm v3 no longer supports.

image

The annotation "helm.sh/resource-policy": keep instructs Helm to skip deleting this resource when a helm operation (such as helm uninstall, helm upgrade or helm rollback) would result in its deletion. However, this resource becomes orphaned. Helm will no longer manage it in any way. This can lead to problems if using helm install --replace on a release that has already been uninstalled, but has kept resources.

Here is documentation as well regarding this topic Helm.

As I'm using helmfile for deployment, and currently pvc template can't exclude this annotation.

image

Sincerely, Igor

Vad1mo commented 3 years ago

@Igor992 could you create a PR with the change, I'll will approve that ASAP

Igor992 commented 3 years ago

@Vad1mo Sure, just to make some free time and I'll push PR.

Igor992 commented 3 years ago

@Vad1mo I think that you need to provide me permission so I can push this little change as PR. 

remote: Permission to 8gears/n8n-helm-chart.git denied to Igor992.
fatal: unable to access 'https://github.com/8gears/n8n-helm-chart.git/': The requested URL returned error: 403
Vad1mo commented 3 years ago

this is not how it usually works. you need to fork and open a PR:

https://www.dataschool.io/how-to-contribute-on-github/

Igor992 commented 3 years ago

Thanks for this documentation! I mostly work in organizational environments so I forgot this approach.

Don't forget to push a new chart with these patch fixes, so others can just reference it :)

image

Sincerely, Igor

Vad1mo commented 3 years ago

0.6.0 is out