search

8go / matrix-eno-bot

An admin and personal assistence Matrix bot built on matrix-nio and nio-template
Apache License 2.0
88 stars 15 forks source link

Fix #16 #19

Closed troglodyne closed 3 years ago

troglodyne commented 3 years ago

Config parser bug, thankfully fairly simple fix once tracked down :)

8go commented 3 years ago

Yes, @troglodyne you found a bug. Excellent. In these cases Yaml returns a boolean data type and not a string. That was the problem. And thank you very much twice. Thank you once for finding it, and thank you a second time for fixing it. Lovely! It is appreciated!

But I have a question regarding the fix. Why not use return self.command_dict["commands"][command]["markdown_convert"] instead of your suggested return not not self.command_dict["commands"][command]["markdown_convert"].

I cannot see any reason why return self.command_dict["commands"][command]["markdown_convert"] would not be better. Is there anything I am missing.

:+1: again @troglodyne

Let's quickly clarify this and get it fixed. If you agree with me that return self.command_dict["commands"][command]["markdown_convert"] (etc.) is better, please change/update your Pull Request so that you take the credit for fixing the bug.

Cheers and :+1:

8go commented 3 years ago

See also issue #16

8go commented 3 years ago

@troglodyne thank you for the PR and fix. As a team we can drive this project forward. Every contributions is highly appreciated. Thanks, :heart: and :+1: