8p / EightPointsGuzzleBundle

⛽️ Integrates Guzzle 6.x, a PHP HTTP Client, into Symfony
MIT License
440 stars 71 forks source link

README.md Usage error #144

Closed lcp0578 closed 6 years ago

lcp0578 commented 6 years ago

It should be

new EightPoints\Bundle\GuzzleBundle\GuzzleBundle()

not new EightPoints\Bundle\GuzzleBundle\EightPointsGuzzleBundle()

thanks

lcp0578 commented 6 years ago

Configuration in config.yml:

eight_points_guzzle: => guzzle:

gregurco commented 6 years ago

@lcp0578 but why? We renamed bundle class name and configuration key in version 7.0. You can see in here: https://github.com/8p/EightPointsGuzzleBundle/blob/v7.0.0/README.md

https://github.com/8p/EightPointsGuzzleBundle/pull/125 - here was decided to rename bundle

lcp0578 commented 6 years ago

oh,but i used composer require eightpoints/guzzle-bundle is it v4.5.3, but to a newcomer like me, it is so confusing. maybe, it make a note for different versions.

gregurco commented 6 years ago

@lcp0578 so, if you install v4.5.3 then you have to read proper readme: https://github.com/8p/EightPointsGuzzleBundle/blob/v4.5.3/README.md

But my suggestion is to upgrade to latest stable version. There are new features, improvements, bug fixes and tests.

lcp0578 commented 6 years ago

Thanks, i will upgrade it.