Deactivate logger/data collector/formatter/log middleware if logging is false

8p / EightPointsGuzzleBundle

⛽️ Integrates Guzzle 6.x, a PHP HTTP Client, into Symfony

MIT License

440 stars 71 forks source link

Deactivate logger/data collector/formatter/log middleware if logging is false #148

Closed gregurco closed 6 years ago

gregurco commented 6 years ago

[ ] Bug fix
[x] New feature
[ ] BC breaks
[ ] Deprecations
[x] Tests pass

Fixed tickets: [#72] License: MIT

@florianpreusner so, if logging in configuration is false, then logger, data collector, formatter and log middleware are not defined at all and visa versa. I also wrote tests for these cases :slightly_smiling_face:

gregurco commented 6 years ago

@florianpreusner good :slightly_smiling_face: I tested and for me it seems to be ok. Could you merge it?

florianpreusner commented 6 years ago

Yip! 👍