8p / EightPointsGuzzleBundle

⛽️ Integrates Guzzle 6.x, a PHP HTTP Client, into Symfony
MIT License
440 stars 71 forks source link

Migrating from 6.x to 7.x. Where is UPDATE.md? #149

Closed DonCallisto closed 6 years ago

DonCallisto commented 6 years ago

Hello guys. I would like to keep my dependencies as updated as possible but with your bundle I cannot be sure that the update would not break all the things. Could you please include an UPDATE.md file to guide everyone in this operation?

Thank you in advance.

DonCallisto commented 6 years ago

Looking at 7.0 release it seems that only configuration files are involved in this process. Can you confirm?

gregurco commented 6 years ago

@DonCallisto 1) if you used wsse middleware then you should install and activate https://github.com/gregurco/GuzzleBundleWssePlugin 2) if you used "headers" config outside of "options" config then you should move them

Besides these I don't remember any other breaking compatible changes.

Good idea about UPDATE.md :+1:

DonCallisto commented 6 years ago

@gregurco I think also configuration file keys (e.g.: guzzle is now eight_points_guzzle) and namespaces should be changed (bundle registration for example; and I suppose it's the only case because I'm browsing through PR(s) and I can't see much more)

gregurco commented 6 years ago

@DonCallisto yep, you are right

DonCallisto commented 6 years ago

So, apart from wsse plugin:

No other actions needed: your switch from PSR-0 to PSR-4 keeping same namespace prefix and mapping PSR-4 to src base directory (with all file moved under src) has granted a sort of "backward compatibility" in class loading. Awesome!

gregurco commented 6 years ago

@DonCallisto please take a look at https://github.com/gregurco/EightPointsGuzzleBundle/blob/6524bf487db7e6d73c6b01264b4611c7bfe57c15/UPGRADE.md Do you have something to add?

DonCallisto commented 6 years ago

@gregurco yes, if you have created any services, you should change name aswell like

before

<argument type="service" id="guzzle.client.xyz" />

after

<argument type="service" id="eight_points_guzzle.client.xyz" />

gregurco commented 6 years ago

@DonCallisto thanks you, I added: https://github.com/gregurco/EightPointsGuzzleBundle/blob/51e45461e40635db3ff525a39ec2ec7422bb07b3/UPGRADE.md

Other remarks/suggestions?

DonCallisto commented 6 years ago

I think that's all!

gregurco commented 6 years ago

@DonCallisto thanks you. I think tomorrow it will be merged.

DonCallisto commented 6 years ago

Thanks! It will be very useful!

florianpreusner commented 6 years ago

Released in v7.2.0 (https://github.com/8p/EightPointsGuzzleBundle/releases/tag/v7.2.0)

DonCallisto commented 6 years ago

Thank you guys