8p / EightPointsGuzzleBundle

⛽️ Integrates Guzzle 6.x, a PHP HTTP Client, into Symfony
MIT License
440 stars 71 forks source link

Added support for Guzzle client options + configuration test #17

Closed asprega closed 9 years ago

asprega commented 9 years ago

Hi! First of all, thanks for the great bundle.

Since there was no way to provide custom default options when instantiating clients (documentation here: http://guzzle.readthedocs.org/en/latest/request-options.html) I added it. I also added a test for the options array I introduced.

@florianpreusner: can you please consider merging this, or let me know if there's anything you don't like? Thanks!

PS: I had to add some dependencies to your composer.json which are in fact real dependencies but were missing after a fresh install. Without them I wasn't able to run tests on my machine. I made sure to add them with a non-strict version requirement so it shouldn't cause problems to anyone already using this bundle.

florianpreusner commented 9 years ago

Hi!

Nice! Really like your changes. Thanks for contributing!

Best regards Florian

asprega commented 9 years ago

Great! Glad you liked it. Looking forward to a new tagged release ;) have a great day

florianpreusner commented 9 years ago

Created v4.1.0 https://github.com/8p/GuzzleBundle/releases/tag/v4.1.0