search

8p / EightPointsGuzzleBundle

⛽️ Integrates Guzzle 6.x, a PHP HTTP Client, into Symfony
MIT License
440 stars 71 forks source link

Fix twig extension incompatibility #185

Closed borisbabic closed 6 years ago

borisbabic commented 6 years ago
Q A
Bug fix yes
New feature no
BC breaks no
Deprecations no
Tests pass yes
Fixed tickets []
License MIT

In twig/twig 1.x Twig_ExtensionInterface declares getName which the current DebugExtension is missing.

gregurco commented 6 years ago

@borisbabic Hello. As I see, DebugExtension extends \Twig_Extension, but not \Twig_ExtensionInterface and \Twig_Extension defines this method in 1.x branch: https://github.com/twigphp/Twig/blob/1.x/lib/Twig/Extension.php#L62 Could you please write more information about the case when you have issue. Write please specific version of twig.

borisbabic commented 6 years ago

In the project I noticed this in the version is 1.23.3.

I assumed the change was in 2.x but it seems like they introduced \Twig_Extension::getName for deprecation in 1.26.0 (https://github.com/twigphp/Twig/commit/71f03df01191053d4559bf4788b0c691346a6c40), sorry about that.

gregurco commented 6 years ago

@borisbabic thank you for contribution :+1: