8p / EightPointsGuzzleBundle

⛽️ Integrates Guzzle 6.x, a PHP HTTP Client, into Symfony
MIT License
440 stars 71 forks source link

Remove jQuery, optimize JS #189

Closed gregurco closed 6 years ago

gregurco commented 6 years ago
Q A
Bug fix yes
New feature no
BC breaks no
Deprecations no
Tests pass yes
Fixed tickets [#188]
License MIT

What I did:

@florianpreusner what do you think? It's not finished and tested good yet but I want to know your opinion. Finally we can move back jQuery anytime if we will observe that some functionality that strictly depends on it appears.

florianpreusner commented 6 years ago
florianpreusner commented 6 years ago

Maybe we can also ask reporter of #188 if this approach resolves the issue.

gregurco commented 6 years ago

@florianpreusner thank you for feedback :slightly_smiling_face: I asked for help with testing in #188 but I will test it too

gregurco commented 6 years ago

@florianpreusner please take a look :) I renamed and normalized all classes to prevent conflicts. I used BOM CSS naming convention. And also I tested and it seems to be ok :slightly_smiling_face:

florianpreusner commented 6 years ago

@gregurco Can you commit a small change to trigger SensioLabsInsight again? I reactivated this check. When there is inactivity the automatic check gets disabled :/

gregurco commented 6 years ago

@florianpreusner triggered, verified and merged :slightly_smiling_face:

florianpreusner commented 6 years ago

@gregurco, Good job! Thanks!