Add support of Symfony 5.x

8p / EightPointsGuzzleBundle

⛽️ Integrates Guzzle 6.x, a PHP HTTP Client, into Symfony

MIT License

440 stars 71 forks source link

Add support of Symfony 5.x #280

Closed gregurco closed 4 years ago

gregurco commented 4 years ago

Q	A
Bug fix	no
New feature	no
BC breaks	no
Deprecations	no
Tests pass	yes
Fixed tickets	-
License	MIT

rpkamp commented 4 years ago

The easiest way to solve supporting both Symfony 4.4 and Symfony 5.0 at the same time wrt the DataCollector is to use a Trait in the datacollector, and then use a different trait for Symfony 4.x than for 5.x.

Basically this: https://github.com/snc/SncRedisBundle/tree/master/DataCollector

gregurco commented 4 years ago

Thank you for idea, @rpkamp Interesting solution :slightly_smiling_face: we have something similar for events.

mihaileu commented 4 years ago

@gregurco what about a new tag ?

mbadolato commented 4 years ago

Would be nice to be able to pull these changes into a Symfony 5 project (currently possible with dev-master but would prefer a tag/release) 😄

gregurco commented 4 years ago

@mihaileu @mbadolato yep, the tag will appear soon :slightly_smiling_face: just few last changes before release.