8p / EightPointsGuzzleBundle

⛽️ Integrates Guzzle 6.x, a PHP HTTP Client, into Symfony
MIT License
440 stars 71 forks source link

Upgrading PHP to 7.2 and two small fixes #291

Closed gabfr closed 4 years ago

gabfr commented 4 years ago
Q A
Bug fix yes
New feature no
BC breaks yes
Deprecations yes
Tests pass yes
Fixed tickets -
License MIT

I had to upgrade the PHP version to 7.2 because it was breaking when I used with Symfony components in v. 5. Since this may be an issue for others too and PHP 7.1 reached EOL I'm sending all the changes I did to make it happen:

I also know that perhaps this is not a so common scenario, but raising this discussion won't hurt anyone.

Thanks!

gabfr commented 4 years ago

This discussion was settled on the #290 PR