search

8p / EightPointsGuzzleBundle

⛽️ Integrates Guzzle 6.x, a PHP HTTP Client, into Symfony
MIT License
440 stars 71 forks source link

Introduce versioning and align with guzzle bundle. #4

Closed m3co-code closed 10 years ago

m3co-code commented 10 years ago

Hey Florian,

I used your convenient bundle to integrate the guzzle library into my project. After doing a composer update it lead to an application error, caused through incompatible changes in the guzzle library, as you only provide dev-master as version and change the dependency on the underlying guzzle bundle in this version. Thus there is no way, as I see it, to work with a fixed version of guzzle when I use your bundle.

Would it be an option to create releases of your repository, according to the versions of guzzle? This is just meant as a feature request and improvement suggestion!

Kind regards, Marco

florianpreusner commented 10 years ago

Hey Marco,

you are absolutely right. Sorry for that. I will fix this issue by creating a new stable version based on a older commit this evening. The usage of guzzle 5 will get a version soon. I guess it is fine to work with guzzle 5 in dev-master. This will solve your problem, right?

Best regards and thanks for your feedback

Florian

-------- Ursprüngliche Nachricht -------- Von: Marco Jantke Datum:22.10.2014 16:52 (GMT+01:00) An: 8p/GuzzleBundle Betreff: [GuzzleBundle] Introduce versioning and align with guzzle bundle. (#4)

Hey Florian,

I used your convenient bundle to integrate the guzzle library into my project. After doing a composer update it lead to an error as you only provide dev-master and change the dependency on the underlying guzzle bundle in this version. Thus there is no way, as I see it, to work with a fixed version of guzzle when I use your bundle.

Would it be an option to create releases of your repository, according to the versions of guzzle? This is just meant as a feature request and improvement suggestion!

Kind regards, Marco

Reply to this email directly or view it on GitHubhttps://github.com/8p/GuzzleBundle/issues/4.

florianpreusner commented 10 years ago

Hi Marco,

now I have created the first tag of this bundle - v1.0.0. This version is using Guzzle 3.7. "dev-master" will be used for development.

This bundle is now using semantic versioning. I'm not going to use same versions like Guzzle cause I think that a separate versioning has more benefits (e.g. if there is a bugfix just for this bundle the patch version should be increased and can be different than on Guzzle project).

Best regards Florian

florianpreusner commented 10 years ago

To use version 1.0.0 please update your composer.json:

"eightpoints/guzzle-bundle": "1.0.0"

m3co-code commented 10 years ago

Great, many thanks! :+1: