Deactivate logging/profiler/data collector completely

8p / EightPointsGuzzleBundle

⛽️ Integrates Guzzle 6.x, a PHP HTTP Client, into Symfony

MIT License

440 stars 71 forks source link

Deactivate logging/profiler/data collector completely #72

Closed florianpreusner closed 6 years ago

florianpreusner commented 7 years ago

When setting the option "logging" to false no logging class should be created. Also the data collector (used for profiler) is not necessary than.

gregurco commented 7 years ago

Could you please provide more details and I will try to implement it :) I see, that now if logging is false, then DevNullLogger will be created with service id eight_points_guzzle.logger. Do you want to not define this service at all in this case or what?

florianpreusner commented 6 years ago

Well, not that easy to remember. Unfortunately I didn't provide more info 🤦‍♂️ . I will take a deeper look into this issue the next couple days.

gregurco commented 6 years ago

I read this issue one more time and probably I understood what did you mean :smile: In 1-2 days I will do PR and you will review the result.

florianpreusner commented 6 years ago

I'm curious 😄

florianpreusner commented 6 years ago

Yeah, that seems to be the solution for the problem I have mentioned :) Nice!