search

8thlight / cob_spec

A fitnesse suite for a web server
24 stars 33 forks source link

End the tyranny of RubySlim #32

Closed paytonrules closed 9 years ago

paytonrules commented 9 years ago

This ports all the rubyslim fixtures over to Java. Patrick and I tested this against a Sinatra server and Dave Torre's server, and are all green.

paytonrules commented 9 years ago

Hey @patrickgombert I've rebased. However I no longer have our friend the sinatra. Well I do but it's at home.

You got anything we could use to verify this?

patrickgombert commented 9 years ago

@paytonrules IIRC https://github.com/davetorre/cobspecpasser was good to go

paytonrules commented 9 years ago

Bah! Dave Torre's doesn't start. But we did find an issue running against jake nations server.

dcmoore commented 9 years ago

Did those recent changes fix the issues with Jake's server? Is this good to merge?

paytonrules commented 9 years ago

Uku has a couple changes I haven't looked at yet.

Jake's server had a couple real issues - but I'm not on a review board tomorrow so hopefully (crosses fingers) we can finally get this in.

On Thu Feb 19 2015 at 5:14:29 PM Dave Moore notifications@github.com wrote:

Did those recent changes fix the issues with Jake's server? Is this good to merge?

— Reply to this email directly or view it on GitHub https://github.com/8thlight/cob_spec/pull/32#issuecomment-75159380.

dcmoore commented 9 years ago

:neckbeard: :+1:

sl4m commented 9 years ago

@heruku ^^

ukutaht commented 9 years ago

With my latest commit, this fork works fully with my own server. I'll try it against @felipesere's implementation today.

paytonrules commented 9 years ago

I did a review of heruku's changes and they look good to me. He's gotten it passing on @felipesere and his own server, so I think we're ready to go.