8thlight / cob_spec

A fitnesse suite for a web server
24 stars 33 forks source link

418 Test #44

Closed ssunday closed 8 years ago

ssunday commented 8 years ago

A test to check if the server correctly implements the 418 code on the appropriate route. The 418 code is a special code with many nuances. Its addition and implementation can add a special something to a server.

KevinLiddle commented 8 years ago

I think google might be a bit wrong on this. I believe 418 is meant to be an error code when someone requests coffee from server that is, in fact, a teapot.

ssunday commented 8 years ago

Google might be a bit wrong on this, but when has right or wrong really played that big a factor in style and design? When all the other cool websites are having 418 codes and teapots showing up wherever and whenever, do you want to be the one with a lame server that doesn't have a teapot route?

I don’t.

KevinLiddle commented 8 years ago

I appreciate your stance on the pleasures of conformity and the importance of trends, but I think we can be better than google and everyone else in this respect by doing things right.

To be clear, I would like to advocate for a route that returns a 418, but that the route name should be coffee, so as to stick to the intended meaning of the 418 error code, where a server that is a teapot cannot give you coffee. (I would think a tea route would return 200 OK, or something else successful).

ssunday commented 8 years ago

Ah. I see your point and I have corrected the test. Now it tests the coffee route for a 418 code and a tea route for a 200 code. I think that is an improvement.

KevinLiddle commented 8 years ago

bitmoji