search

8thlight / cob_spec

A fitnesse suite for a web server
24 stars 33 forks source link

Updated method_options to always include HEAD with GET #46

Closed tommcgee closed 6 years ago

tommcgee commented 8 years ago

As @kevinkotowski noted here HEAD depends on GET, since one might have to hard code behavior to pass my previous test, it defeats the purpose. The quick fix here, is just moving HEAD to the allowed methods, while keeping the dynamic header by not allowing POST, and PUT.

damonkelley commented 8 years ago

:+1:

Also, regarding the commit message for 78c8999, it appears that the reject assertion will just negate the return value of the method. responseHeaderAllowContains will accept a list. However, reject | response header allow contains | PUT,POST does not do a great job of communicating the spec since this will pass as long as at least one of the methods is not present.

saralein commented 6 years ago

Tested it out (and also what @damonkelley was saying out of curiosity). Looks OK to me.