search

8values / 8values.github.io

The 8values political quiz
MIT License
989 stars 411 forks source link

General HTML improvements #43

Closed JoshuaKimsey closed 7 years ago

JoshuaKimsey commented 7 years ago

Added links to the GitHub page for the project for the convenience of the user.

Saphareas commented 7 years ago

@elifoster Well, I thought this was clear. ^^

JoshuaKimsey commented 7 years ago

Yes, I'll be happy to do both! With the link name, I honestly wasn't sure how it should be displayed, so I just took an educated guess at what would look good. So I'm happy for the suggestion on that! As for the mail link, I actually considered doing this to begin with, but I had heard before from others, not associated with this project, that it wasn't always a good idea to have a hyper-link to a mail address, for spam reasons. I don't know if this is a legitimate concern or not, but I'll be more than happy to add the link to the mailing address as well.

JoshuaKimsey commented 7 years ago

Ok, link names have been updated and hyperlinks have been added to the email addresses! Let me know if there's anything else you think should be changed! 🙂

JoshuaKimsey commented 7 years ago

So I went back and was looking at the links I added and I had a question. The links are the standard default blue color that's underlined, since the anchor tags only inherit the styling from the page. My question would be, is the default color and underline good, or should it be different? If y'all think it should be different, what color and style should they be? I'm honestly ok with the blue color, but I figured I'd ask just in case! Any suggestions are welcome!

JoshuaKimsey commented 7 years ago

I decided to add two HTML comments, one to the quiz and the other to the results to show which specific script tag was used for the JavaScript that the test actually uses. It makes it a lot more clear as it was rather confusing with just the one comment about web analytics.

JoshuaKimsey commented 7 years ago

Changed the name of the Pull Request because it has now branched out beyond just adding HTML links to the pages.

JoshuaKimsey commented 7 years ago

As was suggested in an issue request, #46, I have added a line dynamically showing the number of questions currently in the survey.

JoshuaKimsey commented 7 years ago

This pull request is complete on my end! It's just ready to be merged if and/or when y'all think it is ready! 🙂

JoshuaKimsey commented 7 years ago

Is development on this project still occurring? Just wondering due to the length of time this pull request, and the other pull request as well, have been open with no response.

TristanBomb commented 7 years ago

Unfortunately, I have neither the time nor interest to continue this project myself, and I want to deeply apologize for leaving a lot of people hanging. However, there does seem to be a number of people still interested in this project. I have merged the PR, but if anyone is interested in being an official developer, please contact me or reply to this thread. Thanks!