search

8values / 8values.github.io

The 8values political quiz
MIT License
989 stars 411 forks source link

Updated labels in values.svg have missing/different fonts #44

Closed Volvagia356 closed 7 years ago

Volvagia356 commented 7 years ago

The updated labels for "Markets", "Nation", and "World" in values.svg seem to be using a different font from the other labels, or not have a font set entirely.

2017-05-11-024555_879x492_scrot

JoshuaKimsey commented 7 years ago

That's an interesting discovery, I didn't notice this before! I actually think I like the labels for Markets, Nation, and World better, but I also know that sans-serif fonts look better on digital displays, especially smaller sized ones. So with that being said, they all probably need to be the same sans-serif font. I believe if I remember right it was the Google Font "Montserrat" used in the HTML code, but I'm not sure that is the font used in the SVG's. Looks the same to me, but that's not always easy to tell with sans-serif fonts.

Saphareas commented 7 years ago

This won't be an issue anymore, when the localization PR is finally merged, as the text will be rendered seperatly.

TristanBomb commented 7 years ago

Is this still an issue? I've checked the files for those particular icons, and they use SVG paths rather than text. Perhaps I fixed this without closing the issue?

In any case, I would appreciate it if someone who didn't have Montserrat installed checked this.

JoshuaKimsey commented 7 years ago

No, it's definitely still present when I check from an iMac that doesn't have Monserrat installed! You can see here

TristanBomb commented 7 years ago

Aha! The individual icons for the 8 ideologies are fine, it's the combined image that doesn't work. Would you mind checking again to see if it's resolved?

JoshuaKimsey commented 7 years ago

yes indeed! It is now fixed! I'll close the issue for ya! :)