Closed luongngocminh closed 4 weeks ago
Attention: Patch coverage is 70.19231%
with 124 lines
in your changes missing coverage. Please review.
Project coverage is 44.65%. Comparing base (
c459b13
) to head (642b9f1
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@luongngocminh can you update the changes in each comments?
@luongngocminh can you update the changes in each comments?
Can you check the changes again I have already updated it
@luongngocminh nice! So, this could be a replacement of traditional websocket protocol? But how can it handle if subscriber disconnected & later connected again? Will they loose all those messages during disconnected time? Or server will store those & later deliver?
@jibon57 The thought behind this feature is that it's a datachannel, not a message queue or a simple kind of way to do chat applications. It's basically a data delivering passage way, for data to travel around in realtime in a pub/sub manner. So as a developer, you can use these feature APIs to build your own implementation.
Pull Request
Description
Added a virtual datachannel for bi-direction communication between the users in a room. This datachannel is not the same with the WebRTC Datachannel, but it will use the WebRTC Channel to transports the pubsub style messages. A virtual datachannel can be created dynamically via Room Request through the SDK. A Room can have multiple virtual channels.
Checklist