Closed marverlous811 closed 4 months ago
Attention: Patch coverage is 9.40841%
with 1271 lines
in your changes missing coverage. Please review.
Project coverage is 39.94%. Comparing base (
b63e5cf
) to head (a49b745
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@marverlous811
- I generate the answer SDP by fixing the media session and using the public IP of the current node. But I think it is another way to generate a more generic SDP
You can use local-ip-address lib to get current node IP. May be with sip we only need single default IP
- For the transmitted RTP packet flow, I will convert the UDP data to an RTP packet and send it to the Media Endpoint. Is my way okay?
You need transcode it to opus, which is used to send over cluster
NodeJs sample is moved to separated repo:
Pull Request
Description
I added the RTP transport for the SIP call—it is a transport for processing the raw RTP packet without Webrtc. I also added a server using the ng-control protocol, such as an RTP engine, for request calling from the SIP server.
Checklist
Additional Notes
Some problems I faced:
I generate the answer SDP by fixing the media session and using the public IP of the current node. But I think it is another way to generate a more generic SDP
For the transmitted RTP packet flow, I will convert the UDP data to an RTP packet and send it to the Media Endpoint. Is my way okay?