8xFF / atm0s-media-server

Decentralized, Global-Scale Media Server written in Rust (WebRTC/Whip/Whep/Rtmp/Sip)
https://8xff.github.io/media-docs/
MIT License
212 stars 17 forks source link

fix: unsuccessful bind addr cause crash media node #369

Closed giangndm closed 1 month ago

giangndm commented 1 month ago

Pull Request

Description

This PR fix crash bug when some sdn-addr cannot successfully bind or start with more than one worker

Related Issue

If this pull request is related to any issue, please mention it here.

Checklist

Screenshots

If applicable, add screenshots to help explain the changes made.

Additional Notes

Add any additional notes or context about the pull request here.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 89 lines in your changes missing coverage. Please review.

Project coverage is 41.60%. Comparing base (98f938e) to head (41e1279).

Files Patch % Lines
bin/src/main.rs 0.00% 22 Missing :warning:
bin/src/server/media.rs 0.00% 21 Missing :warning:
packages/media_runner/src/worker.rs 0.00% 19 Missing :warning:
packages/transport_webrtc/src/transport.rs 0.00% 14 Missing :warning:
packages/transport_webrtc/src/worker.rs 0.00% 8 Missing :warning:
bin/src/server/media/runtime_worker.rs 0.00% 2 Missing :warning:
bin/src/server/connector.rs 0.00% 1 Missing :warning:
bin/src/server/console.rs 0.00% 1 Missing :warning:
bin/src/server/gateway.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #369 +/- ## ========================================== - Coverage 41.67% 41.60% -0.07% ========================================== Files 134 134 Lines 14310 14333 +23 ========================================== Hits 5963 5963 - Misses 8347 8370 +23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.