8xFF / atm0s-sdn

Global-Scale Ultra-Low Latency Software-Defined Networking powered by Rust
MIT License
59 stars 13 forks source link

chore: clippy fixes #167

Closed dhilipsiva closed 1 month ago

giangndm commented 2 months ago

@dhilipsiva It look like have conflicts after I merge some changes from media-server patch. Can you look at it?

dhilipsiva commented 2 months ago

@giangndm I have carefully resolved all the conflicts and fixed clippy warnings in the media-server patch. If everything looks good to you, we can merge this PR.

giangndm commented 1 month ago

@dhilipsiva Cargo-deny is feedback some warns, then we should have some config like media-server has

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 79.31034% with 36 lines in your changes missing coverage. Please review.

Project coverage is 83.28%. Comparing base (e3ae359) to head (78dce8c).

Files Patch % Lines
packages/network/src/features/vpn.rs 0.00% 6 Missing :warning:
packages/network/src/data_plane.rs 37.50% 5 Missing :warning:
packages/network/src/features/data.rs 55.55% 4 Missing :warning:
packages/network/src/features/router_sync.rs 73.33% 4 Missing :warning:
packages/network/src/base/msg.rs 0.00% 3 Missing :warning:
packages/network/src/features/pubsub/controller.rs 62.50% 3 Missing :warning:
packages/core/identity/src/node_id.rs 50.00% 2 Missing :warning:
packages/network/src/features/alias.rs 95.45% 2 Missing :warning:
packages/network/src/features/pubsub/mod.rs 0.00% 2 Missing :warning:
packages/core/identity/src/conn_id.rs 0.00% 1 Missing :warning:
... and 4 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #167 +/- ## ========================================== + Coverage 83.21% 83.28% +0.06% ========================================== Files 68 68 Lines 9038 9016 -22 ========================================== - Hits 7521 7509 -12 + Misses 1517 1507 -10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

giangndm commented 1 month ago

@dhilipsiva We have some packages which rejected by cargo-deny, can you create a config for cargo-deny like this:

https://github.com/8xFF/atm0s-media-server/blob/master/deny.toml

giangndm commented 1 month ago

@dhilipsiva thank you so much.