9-FS / nhentai_archivist

downloads hentai from nhentai.net and converts to CBZ
MIT License
115 stars 6 forks source link

Not Downloading #1

Closed PK888888 closed 1 year ago

PK888888 commented 2 years ago

A little context, it worked before but today it just won't download anything. I get the usual 'Enter Holy Numbers" but now it's stuck at "Downloading...."

Let me know, thanks!

Edit: Grammar

9-FS commented 2 years ago

Hello PK888888, this is very likely due to cloudflare updating its protection. I can confirm that it also does not work for me anymore either. I'll try to get to it as soon as I can.

9FS

PK888888 commented 2 years ago

Thanks for the prompt reply, no rush just curious if it was just me.

:)) Great tool btw HUGE props!

9-FS commented 1 year ago

Hey @PK888888, it's been a while. I'm happy to announce that with today's patch (more like a complete rewrite), the downloader works again.

Why did it take so long? Basically, I used to scrape the gallery HTML for the image links and then download them. To circumvent cloudflare, my initial thought was to take that to the next level and simulate a whole browser and a user clicking through the gallery to collect the image links. I managed to do that, but it was really unreliable and tended to just randomly crash. I kinda gave up at that point. Things changed when I was made aware that nhentai provides a limited API a couple of days ago. I found a way to access that without all the browser emulating overhead and can now directly download the images.

Btw I also updated the whole project structure and coding style to my today's standard. It was very interesting to see how much I have changed within the last year.

Sorry for taking so long, but I hope you'll still find my tool useful. Have fun!