9-FS / nhentai_archivist

downloads hentai from nhentai.net and converts to CBZ
MIT License
102 stars 6 forks source link

Feature - disable nhentai number in the ComicInfo.xml <Title> #29

Open MrHakisak opened 1 week ago

MrHakisak commented 1 week ago

Love the work you are doing here 9-FS.

I am seeing that the nhentai ID number is put in the title of the ComicInfo.xml field. I would like to disable this, it would make the books look more tidy in a library if it didn't have the number (and also allow more room to display long titles). You wouldn't loose sorting either, because upload date is included in ComicInfo.xml.</p> <p>-Thank you</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/9-FS"><img src="https://avatars.githubusercontent.com/u/94404035?v=4" />9-FS</a> commented <strong> 1 week ago</strong> </div> <div class="markdown-body"> <p>Gude MrHakisak, I agree that having the ID in the <code><Title></code> field is not ideal. Better would be to use a proper field for the ID only like the <code><Number></code> field for example. But nHentai Archivist's created library is currently optimised to be hosted by <a href="https://komga.org/docs/guides/scan-analysis-refresh/#import-metadata-for-cbrcbz-containing-a-comicinfoxml-file">Komga</a> (simply because that's what I use and I don't know a better option) and I couldn't figure out how to search by <code><Number></code> using Komga.</p> <p>I'm not a big fan of introducing another setting for edge cases, adding more complexity and potentially library inconsistencies. So if I'm going to make a change to the ComicInfo.xml, I'd like to do it only once to keep breaking changes to a minimum and fix the situation altogether.</p> <p>So if you have a suggestion on where to put the nhentai ID instead and still be able to search by it using Komga, I'm very open to that change.</p> <p>I currently have Komga categorise every work as a oneshot, so each work's individual tags are used and no tags grouped in series. As I've said, putting nHentai ID in <code><Number></code> does not allow for searching. Another possibility, that has been proposed before, would be to add the ID as a tag, but that would literally create hundreds of thousands of individual tags with 1 entry making the filter by tag sidebar completely unusable. And it wouldn't allow for easily searching by tag either.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/MrHakisak"><img src="https://avatars.githubusercontent.com/u/39749769?v=4" />MrHakisak</a> commented <strong> 1 week ago</strong> </div> <div class="markdown-body"> <p>I am new to Komga and cbz files, but I spent a few hours.</p> <p>I have tried to run a few tests by modifying the ComicInfo.xml, I have tried replacing the number from the title and put it into different fields: Number, Count, Volume, AlternateNumber, AlternateCount, Summary (which shows on komga but can't be searched), Notes, GTIN. I couldn't manage to search using any of those fields.</p> <p>Some things that do work: Putting the ID at the end of the title. Adding the ID as an additional Writer. or any of these fields: Penciller, Letterer, Inker, Editor, Cover, Colorist</p> <p>This is what a oneshot would look like if some of those fields are filled in: <img src="https://github.com/user-attachments/assets/bf951b84-b230-4799-8793-8ad59cdfebae" alt="Screenshot 2024-09-30 203308" /></p> <p>You would search for them here like this: (also note that if you open the dropdown, nothing appears until you start typing, so hopefully if there are +100,000 entries it shouldn't cause issues) <img src="https://github.com/user-attachments/assets/5bf736c0-6d04-4944-a3e9-7082a321c94d" alt="Screenshot 2024-09-30 203415" /></p> <p>Do with this information how you wish (but let me know if you decide against doing any of these changes so I can just start scraping). Also unless there is a software out there that can batch rename every book (let me know if there is), it would mean you would have to re-scrape everything again.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/9-FS"><img src="https://avatars.githubusercontent.com/u/94404035?v=4" />9-FS</a> commented <strong> 1 week ago</strong> </div> <div class="markdown-body"> <p>Okay I didn't know <code><Writer></code> had its own search field. This is pretty cool.</p> <p>I am currently inclined to add the ID in <code><Writer></code> and add a setting to enable having ID additionally in the title just like now, but defaulted to off.</p> <p>Transitioning from the old ComicInfo.xml format to the new will be a pain in the ass though. The best way would probably be to write a helper program to automatically update existing ComicInfo.xml, but that sounds like more time I am currently motivated to spend. Anyone able to jump to the rescue with a quick and dirty python script?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/shinji257"><img src="https://avatars.githubusercontent.com/u/261005?v=4" />shinji257</a> commented <strong> 5 days ago</strong> </div> <div class="markdown-body"> <p>Please don't add the ID into Writer. I have Writer mapped to artist in LANraragi right now and I already modified the file to account for it. As it stands I already have a mini patch that changes how nhentai_archivist writes out the Web field because the nHentai metadata plugin over on LANraragi doesn't expect it to have a protocol set at the start.</p> <p>As it stands the ComicInfo plugin over there isn't able to get the tags from your ComicInfo file. It's probably a bug. One that I have not gone through the trouble to fix so I just pull from nHentai in batches.</p> <p>With all that said I know you are targeting Komga so if you do make a change then I'll adjust depending on the change (if any).</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/9-FS"><img src="https://avatars.githubusercontent.com/u/94404035?v=4" />9-FS</a> commented <strong> 4 days ago</strong> </div> <div class="markdown-body"> <p>Hmm you're making a good point though. <code><Writer></code> is already being used by artists and mixing the field with ID is probably not a good idea.</p> <p>Komga also offers the fields "pencillers", "inkers", "letterers", "cover", "editors", and "translators". Except for "translators", I'm currently using none of the other fields which could then be used to save the ID. This feels pretty random and unexpected though... I wish they would just allow searching by <code><Number></code>.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/MrHakisak"><img src="https://avatars.githubusercontent.com/u/39749769?v=4" />MrHakisak</a> commented <strong> 3 days ago</strong> </div> <div class="markdown-body"> <p><a href="https://github.com/gotson/komga/discussions/1723">I opened a feature request on komga git</a>. They seem kinda active so let's see what they do</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>