search

9-FS / nhentai_archivist

downloads hentai from nhentai.net and converts to CBZ
MIT License
116 stars 7 forks source link

Question/Inquiry - Web field format? #31

Closed shinji257 closed 1 month ago

shinji257 commented 1 month ago

This is a question of curiosity. Is there a reason why you have the app write out the full url rather than a protocol-less entry? Is this a Komga limitation? I'm not asking for a change but I just want to know if there was a specific reason why.

Your line: Web: format!("https://nhentai.net/g/{id}/", id=hentai.id), My edit: Web: format!("nhentai.net/g/{id}", id=hentai.id),

It strips out the protocol and the trailing space on my build as it is unnecessary in LANraragi and the metadata plugin over there expects that however I can completely see the possibility that Komga might not interpret that as a URL.

9-FS commented 1 month ago

To be honest, I just didn't think about that during implementation.

and the metadata plugin over there expects that

Am I understanding this correctly that this causes compatibility issues on your end?

shinji257 commented 1 month ago

Sort of. (typed, retests after seeing regex, then removes and rethinks) It works (it didn't used to) but it results in an extra source entry because the plugin adds a source item as part of its return and it doesn't have the protocol duplicating what was there. At the time (for whatever reason) I opted to have it change how the file is created in your metadata file rather than changing the other plugin's behavior.

Protocol less urls is what LANraragi tends to prefer in their plugins and they also have a script that can convert a source that is just the numbers (6 digits or less) into the url as I prefer it.

This is how it looks using LANraragi stock behavior as of right now. image

This is a rather minor view because I made some other changes on their end for my private install. Changed artist to grab Writer, group to grab Publisher, forced a category tag group on Genre.

So given that I have my own private modifications to LANraragi's plugins I don't expect you to change your program but... if you did make it an option or an override. Maybe have it so that you continue to do the way you are by default with an option field where one might be able to define how the Web URL is formatted out.

Ideal options would be as follows (just a thought): Full URL (default): https://nhentai.net/g/{id} Protocol-less URL (LANraragi): nhentai.net/g/{id} ID only: {id}

9-FS commented 1 month ago

Hi, I have added a test hentai with a protocolless <Web> entry to my library and unfortunately Komga does not seem to like that. I'm rejecting this feature request for the simple reason that if I grant every niche request the source code and configuration options will just become too complex over time. Sorry. :(

shinji257 commented 1 month ago

All good. This wasn't really a request to begin with and I got my answer.