Semicircles not displaying

9-volt / bug-life

Bug Life - GitHub Data Challenge 2014

https://9-volt.github.io/bug-life/

MIT License

63 stars 12 forks source link

Semicircles not displaying #25

Closed joha4270 closed 8 years ago

joha4270 commented 8 years ago

When rendering a repo, the semicircles that display how long each bug lived is gone.

I can reproduce this issue on Chrome 51, Firefox 47 and Edge 38 All on Windows 10 preview

bumbu commented 8 years ago

Hey @joha4270 , Can you please provide a link with an example?

joha4270 commented 8 years ago

Chrome console report lots of

d3.min.js:formatted:169Error: attribute cx: Expected length, "NaN".o @ d3.min.js:formatted:169

I would be perfectly happy to provide more info, but i have no experience in web development so i won't know what information is needed.

ashl1 commented 8 years ago

This is because Chrome removed supports of offsetWidth and offsetHeight (look at jquery/jquery#2889). So this lines provides undefined which produce NaN after scale()

joha4270 commented 8 years ago

Issue is not isolated to chrome. Here is Edge

And Firefox

ashl1 commented 8 years ago

Anyway, the PR is done and it will correct the behavior in all newest browsers (97% supports worldwide) @bumbu could your check the PR #26 and merge it if ok?