search

91861 / wayst

A simple terminal emulator
MIT License
287 stars 9 forks source link

Setting app-id seems to be broken #49

Closed Narrat closed 4 years ago

Narrat commented 4 years ago

Hi I noticed today with a wayst build based on commit 732deea that setting the app-id via --title doesn't work anymore. At least the compositor hikari doesn't pick it up anymore. With a build based on 694f45b it worked. If I get to it later I will bisect this, but maybe you already have an idea what is happening and beat me to it.

Narrat commented 4 years ago

the noticed behaviour was introduced with c81499ac84cefba1adae9cfe0a52d7108549e86f So the issue is more about that it isn't possible anymore to change that specific wm property. Which prevents compositors to apply application specific rules. What is the reasoning behind the hardcoding of Wayst via APP_NAME?

91861 commented 4 years ago

I removed that, so the title could be changed without affecting app id and just forgot to add a dedicated option for it.

What is the reasoning behind the hardcoding of Wayst via APP_NAME?

APP_NAME is the application name used in the desktop file.

Narrat commented 4 years ago

I see. Makes totally sense. Well, glad the possebility is back :D Tested the new option and it works perfectly fine. Therefore closing this issue :)