search

92lleo / WhatsappWebToGo

[android] WhatsApp Web client for your phone/tablet with media support
https://f-droid.org/packages/io.kuenzler.whatsappwebtogo
MIT License
264 stars 43 forks source link

Strip down dependencies #34

Closed Domi04151309 closed 3 years ago

Domi04151309 commented 3 years ago

Removes some unused code and dependencies

92lleo commented 3 years ago

Sorry for my slow response time. Can you edit the "update versions" commit to not bump the sdk and remove the last commit? would be cleaner to merge, as i don't want to squash all of them

Domi04151309 commented 3 years ago

Sure if you can tell me how to do that because I don't.

92lleo commented 3 years ago

Sure, no problem. Basic procedure is https://stackoverflow.com/a/1186549 The commit id you want to change is 0e7f88b In the editor, where you have to change "pick" to "edit", you can remove the line "pick 3b5bdd0 Revert SDK bump" to remove the commit. Then just follow procedure of the stack overflow answer and force push to this PR (I can also do it if you want, but I can also support you in the process, just ping me if you have questions)

Domi04151309 commented 3 years ago

Okay, I think that worked. Vim is really confusing if you've never used it before.

92lleo commented 3 years ago

Yes, perfect, thanks! If you don't want to get into vim and only use a command line editor from time to time, I suggest to go with nano instead of vim

Domi04151309 commented 3 years ago

I did use vim because the git shell automatically opened vim. Usually I'd use Nano on Linux but I did it on Windows.

92lleo commented 3 years ago

In case you want to change it: If you run one of the current git-for-windows installs again, you can choose between vim, nano, (and anoter one?). Idk if it installs nano automatically, then you just could git config --global core.editor "nano"

Domi04151309 commented 3 years ago

Thanks, I'll take a look at it