9505-PNNL / wmpy_power

BSD 2-Clause "Simplified" License

1 stars 1 forks source link

README Functionality Section Issues #1

Closed ijbd closed 4 weeks ago

ijbd commented 1 month ago

openjournals/joss-reviews#7225

ijbd commented 1 month ago

On first read, the penstock flexibility, $f_p$, doesn't appear to be used, and an undefined subscript $f_f$ is used instead.

ijbd commented 1 month ago

Similar issues on Equations 7 through 11 (although I don't see Equation 9).

thurber commented 1 month ago

Thanks for the feedback! @danbroman can you review and update the equations as needed?

danbroman commented 1 month ago

@ijbd thanks for the review. i believe i addressed the errors you found - the Qmax formula was incomplete, and f_m should have been f_p. please let me know if you see any other issues