mkdtimg: make it python2 and python3 compatible (string issues)

96boards-hikey / tools-images-hikey960

Tools and images for HiKey960

BSD 2-Clause "Simplified" License

53 stars 47 forks source link

mkdtimg: make it python2 and python3 compatible (string issues) #37

Closed v0lker closed 5 years ago

hzhuang1 commented 5 years ago

@v0lker I remember that python means python2. Am I right? If we want to use python3, we need to replace "python" by "python3" in the head.

v0lker commented 5 years ago

definitely not on a current archlinux where i just tested it and i seem to remember that fedora would change the default as well, although i'm not sure.

i think it would be better to write it so that it is compatible with both but didn't have the time right now.

v0lker commented 5 years ago

the version i just pushed should work for both, python3 and python2. tested that it creates binary identical output on my machine for all 3 cases (old version, new version with python2, new version with python3).

v0lker commented 5 years ago

ping... any change required on my end?