96boards / meta-96boards

OpenEmbedded BSP Layer for the 96boards.org boards
MIT License
41 stars 59 forks source link

96boards-tools: Package and init the resize-disk script #178

Closed kraj closed 7 years ago

kraj commented 7 years ago

Make this script run once on boot

Signed-off-by: Khem Raj raj.khem@gmail.com

fboudra commented 7 years ago

@khem we may need to disable this feature since it forces to reboot which is a problem in automated validation (in lava for instance). what do you propose for such scenario?

ndechesne commented 7 years ago

don't we already have the systemd service for that? i don't understand why we are adding another one. is that for non-systemd boot?

ndechesne commented 7 years ago

and, also, i don't understand why we are forcing a reboot. we've been using the systemd service at boot for months now, and we never required a reboot.

kraj commented 7 years ago

Hmm, I added a reboot for safety, I have not seen any issues without doing a reboot. Since the resize happens very early there is no data generated yet. so we could disable explicit call to reboot secondly we could remove INITSCRIPT_NAME = "resize-disk" or make it ?= so it can be emptied out.

kraj commented 7 years ago

@ndechesne there is more than just systemd in world :)

kraj commented 7 years ago

I will send another pu to tools. to remove reboot call.

ndechesne commented 7 years ago

@kraj but i thought you were on the right side of the world, the side of systemd ;-)

kraj commented 7 years ago

@ndechesne I have had my revelations !!, the way systemd dissed non-glibc support and optimization for footprint, there always will be alternatives to live by e.g. small iot devices and wifi access point pods.

kraj commented 7 years ago

ok here is v2. Also introduced a PV append to add dependency on SRCREV so fetcher is happy. btw. I plan to move 96boards-tools recipe to meta-oe since it is useful beyond 96boards, hope you are ok with that.

ndechesne commented 7 years ago

@kraj re: moving to meta-oe, i think there is a bit of internal crap in 96boards-tools that doesn't need to be moved to meta-oe.. maybe we should split it a bit, before moving. what is it that you find useful really, beyond the resize scripts?

kraj commented 7 years ago

@fboudra can this be merged now ?

kraj commented 7 years ago

@fboudra can we merge it now that @koenkooi has approved it too