search

97jaz / gregor

Date and time library for Racket
45 stars 10 forks source link

Fixes #14: bug in posix->moment with UTC offset TZs #15

Closed 97jaz closed 8 years ago

97jaz commented 8 years ago

@jackfirth This should address your issue #14. I'll wait on merging it for a while to give you a chance to look it over, if you want.

The fix itself is simple. Most of the added code is to provide better test coverage for moments that use UTC offsets as time zones.

jackfirth commented 8 years ago

Looks great to me! Thank you very much for the quick fix.

As an aside: Gregor seems like the kind of library that could benefit greatly from a QuickCheck style testing framework. There's a racket implementation that could be used, but it might be more trouble than it's worth. Something to think about.

97jaz commented 8 years ago

@jackfirth I like the QuickCheck idea in principle. I'll need to take a closer look. At first glance, I think it would be difficult to use it to test date/time arithmetic without using the Gregor library itself for verification.