Closed tonebacas closed 1 year ago
You are right, I'm not taking into consideration the mode selected when emitting the event. I would change it so that it depends on the selected mode:
FILE_MODE_OPEN_FILE
would fire file_selected
.FILE_MODE_OPEN_FILES
would fire files_selected
.However, I would stick to the naming convention, since I'm using the same as Godot's FileDialog
.
The signal file_selected does not fire when you set the NativeFileDialog file mode to FILE_MODE_OPEN_FILE, and double-click a valid file. However, the signal files_selected does fire under the condition mentioned above.
Also, the signal file_selected does fire when you set file mode to FILE_MODE_SAVE_FILE.
I think the signal firing conditions, and the signal naming should be revised, since there is a lot of ambiguity and confusion around them.
I propose the following: