search

99chan-dev / morbid_obesity

A simple image board software based on kusaba.
1 stars 3 forks source link

clean up navigation links #8

Closed kod99 closed 10 years ago

kod99 commented 10 years ago

I added then in pretty hacky and hardcoded, links in the menu and top of boards like manage and irc could probably be implemented better than the way I did it

twobutts commented 10 years ago

i think some of this was covered in c84f48f29da958dc44f62538268aeed9c121d3b8 #3

twobutts commented 10 years ago

could you check and tell me if that's what you're talking about, or provide specifics if it's not

kod99 commented 10 years ago

Well if we could move the links into the appropriate array rather than just being linked inside of some tables in menu.php that would be sweet

On Sun, Nov 3, 2013 at 11:05 AM, Two Butts notifications@github.com wrote:

could you check and tell me if that's what you're talking about, or provide specifics if it's not

— Reply to this email directly or view it on GitHubhttps://github.com/99chan-dev/morbid_obesity/issues/8#issuecomment-27647464 .

twobutts commented 10 years ago

plan: define array in config.php, iterate to generate links. config.php is not in the repo

in some places the manage.php link is present by default, maybe pull that in too

https://github.com/99chan-dev/morbid_obesity/blob/c84f48f29da958dc44f62538268aeed9c121d3b8/dwoo/templates/menu.tpl#L96-L99 https://github.com/99chan-dev/morbid_obesity/blob/c84f48f29da958dc44f62538268aeed9c121d3b8/dwoo/templates/manage_menu.tpl#L121-L124 https://github.com/99chan-dev/morbid_obesity/blob/c84f48f29da958dc44f62538268aeed9c121d3b8/dwoo/templates/img_header.tpl#L61-L64 https://github.com/99chan-dev/morbid_obesity/blob/c84f48f29da958dc44f62538268aeed9c121d3b8/dwoo/templates/img_footer.tpl#L87-L90

ghost commented 10 years ago

config.php is left out because it contains the db info. I think we should define another file for things like this. I'll open another issue.

twobutts commented 10 years ago

so i committed some code earlier and optimistically closed this issue but it clearly still needs some work

twobutts commented 10 years ago

should be fixed now, just needs proper config as detailed in 994babb96a28b266ff3a9015f2e37ea4b854ab6d

99chan commented 10 years ago

Unf On Nov 13, 2013 4:47 PM, "Two Butts" notifications@github.com wrote:

Closed #8 https://github.com/99chan-dev/morbid_obesity/issues/8.

— Reply to this email directly or view it on GitHubhttps://github.com/99chan-dev/morbid_obesity/issues/8 .

twobutts commented 10 years ago

config.php on dedi is now updated to support this, so deploy at will