99designs / aws-vault

A vault for securely storing and accessing AWS credentials in development environments
MIT License
8.52k stars 820 forks source link

Fix mfa_process compatibility issue on Windows #1255

Open uubk opened 1 month ago

uubk commented 1 month ago

This should address #1241 - windows doesn't have /bin/sh. However, using cmd instead is also not quite straightforward since exec.Command has some pitfalls on windows. This implements the suggested upstream workaround and allows us to launch mfa_process correctly on windows, even if the binary is in a path with spaces.