search

99designs / aws-vault

A vault for securely storing and accessing AWS credentials in development environments
MIT License
8.41k stars 815 forks source link

Feedback on `clear` command #645

Closed mtibben closed 4 years ago

mtibben commented 4 years ago

I've just merged the addition of a clear command in the latest v6 beta - see #644 #591 #412

I initially wanted to use the existing rm --sessions-only to achieve this, but found too many inconsistencies between add vs rm, specifying a profile vs no profile and sessions vs oidc token, so fell back to the original proposal of a clear command which had none of the inconsistencies.

Please feel free to test clear (clears sessions/tokens), the changes to list with sessions and oidc tokens displayed in the Sessions column, and rm now being used for long-term credentials (but still supporting the old flag for full backwards compatibility).

Any feedback welcome those who have commented so far @pda @olfway @rossmckelvie @nitrocode @FernandoMiguel @scalp42 @tomelliff and anyone else with an interest.

If this works out for everyone I think we're ready for a v6 release finally 😅

FernandoMiguel commented 4 years ago

Uhhh a full release.. Such a long time coming

mtibben commented 4 years ago

Yeah the v5 release was a little rushed, didn't want to make the same mistake twice but it's taken a little while getting here

FernandoMiguel commented 4 years ago

Since I use aws sso been on v6 since it was made available and got rid of the sportradar docker. I missed aws-vault ease and multi role so much

Thank you and the other contributors so much

FernandoMiguel commented 4 years ago

https://github.com/99designs/aws-vault/blob/master/USAGE.md#removing-credentials Should this bit of the docs be updated to use clear instead?

FernandoMiguel commented 4 years ago

Never mind.. It's below

mtibben commented 4 years ago

ok fixed

ajkerrigan commented 4 years ago

Thanks everyone for all the work on this - the new clear command is helpful, and the tweaks to list are welcome. Things feel really solid at this point, and equally smooth with or without SSO. 👏

olfway commented 4 years ago

Works for me, thanks @mtibben !

noticed a small inconsistency with expired sessions:

❯ aws-vault list
root                      root                            sts.GetSessionToken:-31m50s

Shows there is one (expired) session

❯ aws-vault clear
Cleared 0 sessions.

Says zero sessions was cleared

But actually session was cleared

❯ aws-vault list
root                       root                           -
mtibben commented 4 years ago

v6 released 🎉