modularized colorific library

99designs / colorific

Automatic color palette detection

ISC License

700 stars 55 forks source link

modularized colorific library #14

Closed gkmngrgn closed 11 years ago

gkmngrgn commented 11 years ago

all tests are OK.
pep8 & pyflakes checking are OK.
defined standard get_version() method to get colorific version in code.
read requirements.pip file to get dependency information in setup.py
modularized colorific library, backward compatibility.

dhotson commented 11 years ago

Wow, this is some great work. Thank you very much! :-)

I'll see if @larsyencken and I can set aside some time to review / test your changes and get them merged this week sometime.

larsyencken commented 11 years ago

Thanks for the cleanup, it's much appreciated!

My only gripe: the get_version() dance actually means pip install colorific in a virtualenv fails, because importing colorific imports palette, and that imports packages like PIL which might not be there yet.

If you can resolve that and get pip installs working again, I'll happily merge it in.

gkmngrgn commented 11 years ago

@larsyencken oh shit! it's my wrong, now, I'm thinking to find a way.

larsyencken commented 11 years ago

Nice work, thanks again!