Refactored the Http\Client class such that all code dealing directly with curl now resides in Http\Transport, this will enable certain types of testing/mocking that wasn't previously possible when dealing with the Http\Client.
Obviously a lot of fairly important code depends on this so it warrants a fair degree of scrutiny, a means to properly test the Transport would be nice too.
Additionally the Transport has three methods on it: setTimeout, setHttpProxy & setHttpAuth. These three methods don't really feel like they belong on this class, but as yet I've come up with no solution for removing them, idea's welcome.
lox
commented
13 years ago
Refactored the Http\Client class such that all code dealing directly with curl now resides in Http\Transport, this will enable certain types of testing/mocking that wasn't previously possible when dealing with the Http\Client.
Obviously a lot of fairly important code depends on this so it warrants a fair degree of scrutiny, a means to properly test the Transport would be nice too.
Additionally the Transport has three methods on it: setTimeout, setHttpProxy & setHttpAuth. These three methods don't really feel like they belong on this class, but as yet I've come up with no solution for removing them, idea's welcome.