99designs / ergo

A lightweight php5 library for request/response routing, controllers and http interaction.
http://99designs.com
MIT License
29 stars 4 forks source link

Provide more detail in exceptions resulting from curl errors #15

Closed rbone closed 11 years ago

rbone commented 11 years ago

This pull request adds the curl error number and timing information to exceptions resulting from curl errors.

richo commented 11 years ago

Worth trying to log the URL and params as well (does this expose an info leak in commerce?)

Right now it's pretty possible to infer it from the stack trace, but in many cases it'd be handy to track down an error, I suspect.

richo commented 11 years ago

EDIT: Definitely useful in the case of loadbalanced connections, ie elasticsearch.

rbone commented 11 years ago

@richo Sounds good to me. I've added the url to the exception message including the query string.

richo commented 11 years ago

Nice one. :ship: it.