search

99designs / http-signatures-guzzlehttp

Guzzle 6 support for 99designs http-signatures library
MIT License
12 stars 10 forks source link

Update to Guzzle 6.0 #7

Closed vinkla closed 8 years ago

vinkla commented 9 years ago

This is the WIP PR for Guzzle 6.0 support. We also need tests for this. This is is just an idea on how we should go about adding support for the latest version of Guzzle.

navitronic commented 8 years ago

Hi @vinkla, thanks for putting this together and sorry for not reviewing it sooner. Seems that there is quite a lot going on this PR.

Could you please pull: da8a082, 12dec6c and a8ac014 into separate PR's to make the actual Guzzle 6 changes easier to review.

navitronic commented 8 years ago

Another thing to look at, in Message and MessageHeaders, you will need to look into using: GuzzleHttp\Psr7\Request, as GuzzleHttp\Message\RequestInterface no longer exists.

vinkla commented 8 years ago

It might be better if we close this for now. I don't have a lot of time and it is maybe better if we instead use this pull request as a reference for future updates instead of making it work. Thanks for reviewing and let me know if I can help out with anything else.

navitronic commented 8 years ago

@vinkla no worries. Thanks for the effort so far.

Definitely be able to use some of this in the future. :+1:

vinkla commented 8 years ago

:+1: Keep up the good work!

rubensayshi commented 8 years ago

@vinkla @navitronic I'm looking at this now and to me it looks like it would make the most sense if the 99designs/http-signatures-php package would be changed to use PSR7 entirely and then the guzzle middleware is a breeze ...