search

99designs / http-signatures-guzzlehttp

Guzzle 6 support for 99designs http-signatures library
MIT License
12 stars 10 forks source link

Guzzle6 (using PSR7) #8

Closed rubensayshi closed 7 years ago

rubensayshi commented 8 years ago

depends on https://github.com/99designs/http-signatures-php/pull/22 (PSR-7 support)

rubensayshi commented 8 years ago

because of the switch to using PSR-7 PR this repo is actually becoming VERY small, basicly just a helper function and a few tests, maybe we can just move the class to http-signatures-php

the only reason I can think of for not doing that is because we've experienced quite a bit of pain in the past with new guzzle versions and then we'd have to deal with that pain in that repo ...

however now that PSR-7 is around it's a lot less likely that there will be a lot of pain ...

navitronic commented 8 years ago

Are you able to update this now that http-signatures has landed PSR-7 support? If not, I can take what you've done here and run with it.

rubensayshi commented 8 years ago

yea, updating now! :rocket:

so essentially the v1.x releases are guzzle 4/5 and this will be tagged as v2.x for guzzle 6 right?
and incase a bug is ever found that also affects the older v1.x version it needs to be backported right?

rubensayshi commented 8 years ago

in the meantime guzzle is already on 6.2, so added a matrix of guzzle versions like it had before

rubensayshi commented 8 years ago

ready for review / merge

navitronic commented 7 years ago

This looks good.

I am going to merge and test on a project of ours that uses this library.

rubensayshi commented 7 years ago

@navitronic time to tag a new version?