search

99designs / http-signatures-php

Sign and verify PSR-7 HTTP messages in PHP.
MIT License
44 stars 32 forks source link

php-cs-fixer normalized formatting etc. #20

Closed pda closed 8 years ago

pda commented 8 years ago

Addendum to #13; automated reformatting by php-cs-fixer.

$ php-cs-fixer --version
PHP CS Fixer version 1.10 by Fabien Potencier

$ php-cs-fixer fix src/
   1) Algorithm.php
   2) Context.php
   3) HeaderList.php
   4) HmacAlgorithm.php
   5) KeyStore.php
   6) KeyStoreInterface.php
   7) Signature.php
   8) SignatureParameters.php
   9) SignatureParametersParser.php
  10) Signer.php
  11) SigningString.php
  12) SymfonyRequestMessage.php
  13) Verification.php
  14) Verifier.php
Fixed all files in 4.107 seconds, 6.250 MB memory used
navitronic commented 8 years ago

lgtm :shipit:

vinkla commented 8 years ago

What about integrating https://styleci.io? It can even fix these kind of pull request from the website. It is an awesome tool.

pda commented 8 years ago

I'm not against that, but I'm not sure it's worth the extra moving parts for a low-churn codebase like this.

vinkla commented 8 years ago

Ping @GrahamCampbell

GrahamCampbell commented 8 years ago

Can be useful to avoid having to run php-cs-fixer locally. You can get it to send you a pull request with cs fixes if you push some bad code.