PSR-7 Support - Githubissues

99designs / http-signatures-php

Sign and verify PSR-7 HTTP messages in PHP.

MIT License

44 stars 32 forks source link

PSR-7 Support #22

Closed rubensayshi closed 8 years ago

rubensayshi commented 8 years ago

extended https://github.com/99designs/http-signatures-php/pull/19

added custom HttpMessageFactory to avoid query string being reordered.
added some more type hints for methods.

vinkla commented 8 years ago

:+1:

rubensayshi commented 8 years ago

looking forward to seeing this merged, any feedback?

rubensayshi commented 8 years ago

ping @vinkla

tests only fail because somehow my removal of php 5.3 from .travis.yml didn't 'work', maybe cuz it's a PR ...

vinkla commented 8 years ago

Yeah, some of the dependencies require >=5.4.

vinkla commented 8 years ago

The psr7 package require at least >=5.4.0.

rubensayshi commented 8 years ago

ping @vinkla @navitronic

vinkla commented 8 years ago

IMO we should even drop 5.4. PHP 5.5 will also be see end of life soon.

navitronic commented 8 years ago

Hi @rubensayshi,

I'd pretty much missed this.

Will review over the weekend and get back to you.

cheers,

Adrian

navitronic commented 8 years ago

@rubensayshi Thanks again for this, I have merged this into my PR and am doing some tweaks to it, hoping to merge it into master and have a new release available soon.

rubensayshi commented 8 years ago

awesome! let me know if there's anything I can do to help, review or test!

also once you have it stable I can update https://github.com/99designs/http-signatures-guzzlehttp/pull/8 which also works as a good extra test before you merge it ;-)