99designs / http-signatures-php

Sign and verify PSR-7 HTTP messages in PHP.
MIT License
44 stars 33 forks source link

Use RequestInterface instead of MessageInterface #27

Closed navitronic closed 8 years ago

navitronic commented 8 years ago

Currently, this library uses the following request methods:

The first three are defined as part of Psr\Http\Message\MessageInterface, but the last two methods are defined as part of Psr\Http\Message\RequestInterface. So, this PR updates the various phpDoc statements to reference RequestInterface instead.

It also removes the type hinting from method signatures for the PSR-7 interfaces. We use such a small subset of the PSR-7 spec, that enforcing that anything passed into these methods matches these interfaces seems like overkill and makes writing code that integrates with this library a pain.