Digest enhancements - Githubissues

liamdennehy commented 6 years ago

Move Digest features to BodyDigest class, introduce DigestException
Integrate digest validation with signature validation:
- isValidDigest() checks validity of digest header only
- isValidWithDigest checks digest validity, inclusion in signature, and signature. Any false is a failure (ie signature MUST include a valid digest value for the supplied body)
Supports SHA256 (default), SHA512, SHA1
Tests

mtibben commented 5 years ago

Can you rebase on master where we've got some improved CI steps

liamdennehy commented 5 years ago

I think this is basically done as soon as the comments above are cleared up, I'd very much like to see this merged.

That said, this is not a RFC2617-compliant Digest header implementation (e.g. only accepts/produces a single digest value, limited hashes) but usable under the Signing HTTP Messages scope - and especially important it correctly passes the reference tests. If we need full compliance then either extend this in a subsequent PR, or make/use a dedicated library, but for now I think it does the job and I'm happy to merge as of https://github.com/99designs/http-signatures-php/pull/40/commits/9774e40fd8726aeba8198f69a0e3d4a21b7f8441.

liamdennehy commented 5 years ago

I have integrated this feature in my own project along with a number of others, and published this in packagist. Documentation for the entire library is published at Read the Docs: http-signatures-php - incomplete but being expanded regularly.

liamdennehy commented 5 years ago

Closing PR due to inactivity.

99designs / http-signatures-php

Digest enhancements #40