[fix] Make keyring.Keys() follow symlink to keyring; updated unit tests

99designs / keyring

Go library providing a uniform interface across a range of secure credential stores

MIT License

580 stars 138 forks source link

[fix] Make keyring.Keys() follow symlink to keyring; updated unit tests #63

Closed stefancocora closed 3 years ago

stefancocora commented 4 years ago

Useful for when passwordstore.org is behind a symlink The std lib os.Stat() doesn't differentiate between dir or symlink, had to be replaced by os.Lstat() + handle following the symlink when it exists

Fixes https://github.com/99designs/keyring/issues/62

stefancocora commented 4 years ago

Waiting on for a fix to be put in places for the changes introduced in https://github.com/99designs/keyring/pull/61 which have broken CI on the osx builder and are affecting PRs newer than 61

initial broken build https://travis-ci.org/99designs/keyring/builds/648739232

stefancocora commented 4 years ago

Since you've moved the CI system to github actions the isn't any blocker for this src code to be fully CI tested. :+1:

toothbrush commented 4 years ago

Greetings! I don't want to be an entitled freeloader, but i'm currently blocked by this issue. Is it likely that this patchset will get merged? Thanks for open-sourcing aws-vault! :raised_hands:

stefancocora commented 3 years ago

Have you had any time to look at the changes in https://github.com/99designs/keyring/pull/63 ?

mtibben commented 3 years ago

Using the pass.go from master, all the tests here still pass, so it doesn't seem the tests are working as expected

mtibben commented 3 years ago

Can't reproduce this issue. Test added in d531d42